csv export options need to be HashWithIndifferentAccess #2741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshibuya
reviewed
Nov 5, 2016
| @@ -32,6 +32,7 @@ def initialize(objects = [], schema = {}) | |||
| end | |||
|
|
|||
| def to_csv(options = {}) | |||
| options = HashWithIndifferentAccess.new(options) | |||
There was a problem hiding this comment.
Calling symbolize_keys! would be a bit simpler, I guess.
There was a problem hiding this comment.
I guess this is easier but I prefered to use the safest option. First, not knowing the rest of the code and the consequences, I prefered to be able to use string and symbol as keys, to be safe. Also, you suggestion would actually be to use .deep_symbolize_keys!
At least using HashWithIndifferentAccess, I am sure I am not introducing any regression.
|
Test code needed. |
|
Can be merged when rubocop offenses are resolved. |
|
done. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a correction for this bug.
#2740